Skip to content

[eslint-plugin-react-hooks] fix exhaustive deps lint rule with component syntax #33182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

[eslint-plugin-react-hooks] fix exhaustive deps lint rule with component syntax #33182

merged 1 commit into from
May 15, 2025
+65 −2

Conversation

@kassens
Copy link
Member

@kassens kassens commented May 12, 2025 •
edited
Loading

No description provided.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 12, 2025
@react-sizebot
Copy link

react-sizebot commented May 12, 2025 •
edited
Loading

Comparing: 5d04d73...1b0ffa7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 528.09 kB 528.09 kB = 93.17 kB 93.17 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 646.40 kB 646.40 kB = 113.71 kB 113.71 kB
facebook-www/ReactDOM-prod.classic.js = 674.15 kB 674.15 kB = 118.41 kB 118.41 kB
facebook-www/ReactDOM-prod.modern.js = 664.43 kB 664.43 kB = 116.81 kB 116.81 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1b0ffa7

@kassens kassens merged commit 4448b18 into facebook:main May 15, 2025
478 of 497 checks passed
@kassens kassens deleted the pr33182 branch May 15, 2025 16:51
github-actions bot pushed a commit that referenced this pull request May 15, 2025
@kassens
[eslint-plugin-react-hooks] fix exhaustive deps lint rule with compon…
76773c6 
…ent syntax (#33182)

DiffTrain build for [4448b18](4448b18)
github-actions bot pushed a commit that referenced this pull request May 15, 2025
@kassens
[eslint-plugin-react-hooks] fix exhaustive deps lint rule with compon…
129579c 
…ent syntax (#33182)

DiffTrain build for [4448b18](4448b18)
github-actions bot pushed a commit to code/lib-react that referenced this pull request May 15, 2025
@pull
[eslint-plugin-react-hooks] fix exhaustive deps lint rule with compon…
0ef3292 
…ent syntax (facebook#33182)

DiffTrain build for [4448b18](facebook@4448b18)
github-actions bot pushed a commit to code/lib-react that referenced this pull request May 15, 2025
@pull
[eslint-plugin-react-hooks] fix exhaustive deps lint rule with compon…
c8270bf 
…ent syntax (facebook#33182)

DiffTrain build for [4448b18](facebook@4448b18)
This was referenced May 16, 2025
Closed
Merged
Merged
Closed
Closed
Closed
@eps1lon eps1lon mentioned this pull request Jun 7, 2025
Merged
17 tasks
yungsters pushed a commit that referenced this pull request Jun 13, 2025
@kassens @yungsters
[eslint-plugin-react-hooks] fix exhaustive deps lint rule with compon…
97f2541 
…ent syntax (#33182)
This was referenced Jun 23, 2025
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poteto poteto poteto approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kassens @react-sizebot @poteto @facebook-github-bot