Skip to content

Conversation

@rickhanlonii
Copy link
Member

Noop detection for xplat syncs broke because eslint-plugin-react-hooks uses versions like:

  • 0.0.0-experimental-d85f86cf-20250514

But xplat expects them to be of the form:

  • 19.2.0-native-fb-63d664b2-20250514

This PR fixes the noop by ignoring eslint-plugin-react-hooks/package.json changes. This means we won't create a sync if only that package.json changes, but that should be rare and we can follow up with better detection if needed.

Example failed action:

Screenshot 2025-05-15 at 11 31 17 AM

I believe the regression was caused by #33104

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 15, 2025
@react-sizebot
Copy link

Comparing: 203df2c...f50ac1f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 529.74 kB 529.74 kB = 93.49 kB 93.49 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.48 kB 651.48 kB = 114.75 kB 114.75 kB
facebook-www/ReactDOM-prod.classic.js = 675.72 kB 675.72 kB = 118.84 kB 118.84 kB
facebook-www/ReactDOM-prod.modern.js = 666.00 kB 666.00 kB = 117.23 kB 117.23 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against f50ac1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants