[Flight] Add a Node.js Web Streams bundle for unbundled client/server for Webpack #33442
+167
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
Jun 5, 2025
| i, | ||
| e | ||
| ); | ||
| }; |
There was a problem hiding this comment.
These ones are stateful registers so we need to register with both bundles since each has its own map.
sebmarkbage
force-pushed
the
nodewebstreamwebpack
branch
from
0803435 to
32d2e87
Compare
|
I'm not going to enable any tests for these. I'm also not going to enable types for the rest of them. |
unstubbable
approved these changes
Jun 5, 2025
sebmarkbage
force-pushed
the
nodewebstreamwebpack
branch
from
32d2e87 to
4fc8543
Compare
This was referenced Jun 6, 2025
sebmarkbage
added a commit
that referenced
this pull request
Jun 6, 2025
) Follow up to #33442. This is the bundled version. To keep type check passes from exploding and the maintainance of the annoying `paths: []` list small, this doesn't add this to flow type checks. We might miss some config but every combination should already be covered by other one passes. I also don't add any jest tests because to test these double export entry points we need conditional importing to cover builds and non-builds which turns out to be difficult for the Flight builds so these aren't covered by any basic build tests. This approach is what I'm going for, for the other bundlers too.
sebmarkbage
added a commit
that referenced
this pull request
Jun 6, 2025
sebmarkbage
added a commit
that referenced
this pull request
Jun 6, 2025
Reverts #33457, #33456 and #33442. There are too many issues with wrappers, lazy init, stateful modules, duplicate instantiation of async_hooks and duplication of code. Instead, we'll just do a wrapper polyfill that uses Node Streams internally. I kept the client indirection files that I added for consistency with the server though.
This was referenced Jun 6, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #33441 but for Flight.
This is just one of the many combinations needed. I'm just starting with one.