Skip to content

Conversation

@gnoff
Copy link
Collaborator

@gnoff gnoff commented Jun 6, 2025

When a deep Suspense boundary is partially complete before a parent boundary resolves it can trigger a scenario that React thinks is a bug. This change implements a test case demonstrating this bug. It does not solve it

Can't actually merge til we fix

When a deep Suspense boundary is partially complete before a parent boundary resolves it can trigger a scenario that React thinks is a bug. This change implements a test case demonstrating this bug. It does not solve it
@gnoff gnoff force-pushed the failing-suspense-test branch from d498ee9 to 27bcc64 Compare June 6, 2025 05:53
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 6, 2025
@react-sizebot
Copy link

Comparing: b175988...27bcc64

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.07 kB 530.07 kB = 93.57 kB 93.57 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.16 kB 651.16 kB = 114.70 kB 114.70 kB
facebook-www/ReactDOM-prod.classic.js = 676.11 kB 676.11 kB = 118.97 kB 118.97 kB
facebook-www/ReactDOM-prod.modern.js = 666.39 kB 666.39 kB = 117.36 kB 117.36 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 27bcc64

@gnoff
Copy link
Collaborator Author

gnoff commented Jun 6, 2025

test incorporated into #33467 and fixed there

@gnoff gnoff closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants