Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Aug 11, 2025

When we reconciled the fallback, we popped back up Suspense nodes. We can't pop back up before removedPreviousSuspendedBy.

We immediately push back the stack now. This allows us to unify the measure calls.

@meta-cla meta-cla bot added the CLA Signed label Aug 11, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 11, 2025
@eps1lon eps1lon requested a review from sebmarkbage August 11, 2025 13:57
@eps1lon eps1lon marked this pull request as ready for review August 11, 2025 13:58
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work since we know the suspense node is local to the scope but this might not work more generally eg for other instances because the thing shadowed isn’t immutable. Sometimes we need to update the thing like the previous sibling and if there’s another concept of that higher up in the stack then that won’t get properly mutated.

So in general this kind of popping up in a deeper stack doesn’t work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants