[compiler] Don't leak global __DEV__ type
#34551
Merged
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel-plugin-react-compileris not providing a global__DEV__so it shouldn't declare its type. Whatever is providing this global should declare the types.This prevents including
__DEV__in autocomplete when that variable may never be available.This was especially problematic if you had an existing
__DEV__declared because thenbabel-plugin-react-compilerwould fail since you can't re-declare block scoped variables.Diff for
dist/index.d.tsdeclare global { - let __DEV__: boolean | null | undefined; }