[playground] ViewTransition on config expand #34595
Merged
+238
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackpope
approved these changes
Sep 25, 2025
| onToggle={setIsExpanded} | ||
| onToggle={() => { | ||
| startTransition(() => { | ||
| addTransitionType('config-panel'); |
There was a problem hiding this comment.
This type could be a constant as its important it matches across usages through these modules but should also be unique from anything used in future unrelated transitions.
You could have something like apps/playground/lib/transitionTypes.ts where you export from.
|
I just noticed when you have show internals on the collapsed tabs fade instead of slide. It should be possible to put a container around the remaining tabs and slide those as well. |
jackpope
approved these changes
Sep 29, 2025
This was referenced Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduced
<ViewTransition>to the React Compiler Playground. Added an initial animation on the config panel opening/closing to allow for a smoother visual experience. Previously, the panel would flash in and out of the screen upon open/close.How did you test this change?
Screen.Recording.2025-09-29.at.1.56.35.PM.mov