Fix "go to label" in bazel LSP #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing "go to definition" on a label, it would previously go to the correct file but not to the definition of that target. The reason was because we were searching for a function call where the name is the whole label. Now it parses the label to extract the name and searches using that. This doesn't work in a few cases, for example "//foo" and "@foo", where the name is implicit. However, I think to solve this we would need to implement a label parser. If one already exists, I could not find it. I imagine a lot of the code in `resolve_folder` could be simplified with the use of a label parser too.
facebook-github-bot
added
the
CLA Signed
|
Nice! Works well for local targets for me :) and handles |
Contributor
Author
|
That's strange. It works for going to external repositories for me, just not when in a file in an external repository. |
|
Good! My bad, I had the runfiles library as the abbreviated package-only label. With |
cameron-martin
added a commit
to cameron-martin/starlark-rust
that referenced
this pull request
Dec 20, 2023
Instead of parsing labels ad-hoc in `resolve_folder`, this introduces a separate label parser. This allows re-using this when doing a "go to definition" for a label that is not in a load statement. See facebook#100 for more context.
Contributor
Author
|
With #101 I will be able to fix this problem |
cameron-martin
added a commit
to cameron-martin/starlark-rust
that referenced
this pull request
Jan 2, 2024
Instead of parsing labels ad-hoc in `resolve_folder`, this introduces a separate label parser. This allows re-using this when doing a "go to definition" for a label that is not in a load statement. See facebook#100 for more context.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
Summary: Instead of parsing labels ad-hoc in `resolve_folder`, this introduces a separate label parser. This allows re-using this when doing a "go to definition" for a label that is not in a load statement. See #100 for more context. Pull Request resolved: #101 Reviewed By: stepancheg Differential Revision: D52887102 Pulled By: ndmitchell fbshipit-source-id: e08c07b3d88c24d14030568dcc3ecf33ae8c243c
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Jan 19, 2024
Summary: Instead of parsing labels ad-hoc in `resolve_folder`, this introduces a separate label parser. This allows re-using this when doing a "go to definition" for a label that is not in a load statement. See facebook/starlark-rust#100 for more context. X-link: facebook/starlark-rust#101 Reviewed By: stepancheg Differential Revision: D52887102 Pulled By: ndmitchell fbshipit-source-id: e08c07b3d88c24d14030568dcc3ecf33ae8c243c
Contributor
|
Any reason not to undraft this? |
Contributor
Author
Yep I was waiting for the label parser to go in so I could use it here. I'll update this soon and undraft it. |
Contributor
Author
|
@ndmitchell This should be now good to go! |
Contributor
|
@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Jan 22, 2024
Summary: When executing "go to definition" on a label, it would previously go to the correct file but not to the definition of that target. This was because we were searching for a function call where the name is the whole label. Now it parses the label, using the label parser introduced in facebook/starlark-rust#101, to extract the name and searches using that. X-link: facebook/starlark-rust#100 Reviewed By: wendy728 Differential Revision: D52954185 Pulled By: ndmitchell fbshipit-source-id: 937da257b7441d8abe313015ca1c8241c7967a10
Contributor
|
@ndmitchell merged this pull request in 1f2fe80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing "go to definition" on a label, it would previously go to the correct file but not to the definition of that target. This was because we were searching for a function call where the name is the whole label. Now it parses the label, using the label parser introduced in #101, to extract the name and searches using that.