Added matrix_to_axis_angle to the exports of transforms
#1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`matrix_to_axis_angle` was declared in `pytorch3d/transforms/rotation_conversions.py` but never exported from the `__init__` file.
facebook-github-bot
added
the
CLA Signed
Contributor
|
@bottler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 21, 2022
Summary: # Changelist - `matrix_to_axis_angle` was declared in `pytorch3d/transforms/rotation_conversions.py` but never exported from the `__init__` file. Pull Request resolved: #1085 Reviewed By: patricklabatut Differential Revision: D34379935 Pulled By: bottler fbshipit-source-id: 993c12a176630f91d0f107f298f458b2b35032e5
Contributor
|
@Theo-Cheynel Thank you for this fix! |
Contributor
Author
|
You're welcome! It's been bugging me for a while now haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
matrix_to_axis_anglewas declared inpytorch3d/transforms/rotation_conversions.pybut never exported from the__init__file.