Skip to content

Conversation

rogerluan
Copy link
Member

Auto-generated by fastlane bot 🤖

@fastlane-bot-helper
Copy link
Collaborator

2 Warnings
⚠️ mkdocs.yml was modified - make sure no modification was made by mistake
⚠️ It seems like the page hipchat: actions/hipchat.md got removed from mkdocs.yml, we don't want to remove any public links. Instead please add a redirect to the new page.

Generated by 🚫 Danger

@ccaruceru
Copy link

@rogerluan hi! any chance we can deploy these updated docs? 🙏🏻

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this 🚢

@rogerluan
Copy link
Member Author

@AliSoftware it's failing Netlify preview, and auto deploys on master are also not working AFAICT 😕 we can merge it but it won't be deployed

@iBotPeaches
Copy link
Contributor

@rogerluan - Could you point me to where you believe master deploys are broken? I see the Netlify Preview is busted, which appears to be a default configuration on Josh's account. We could probably workaround that by introducing a netlify config to set it back to a Pipfile build.

However, it seems 8 months ago Josh wired up CI/CD to GitHub actions - https://github.com/fastlane/docs/actions/runs/13134104062 and that went out on 2025-02-04 which looks live on the website. So I'm under belief that only previews are broken, but not merges.

Screenshot 2025-10-14 at 11 54 54 AM

I'll work on a blind PR today to fix previews, but I think real merges are good. So I'm +1 for this merge.

@iBotPeaches
Copy link
Contributor

@rogerluan - When I added a netlify.toml to force change the configuration, my preview worked - #1284

Though build itself is failing from the HipChat stuff, so hope this helps to push this stuff forward.

@rogerluan
Copy link
Member Author

Thanks for this @iBotPeaches ! Let's get this merged and see if it gets deployed, then I'll test your PR later :)

@rogerluan rogerluan merged commit 74e4d42 into master Oct 15, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants