Make js version usable in npm #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
reviewed
Oct 6, 2022
dmsnell
reviewed
Oct 6, 2022
|
@michal-kurz good catch on this. there's something else to consider here: considering that we're pulling in extra characters into the patch context, I guess there's still a possibility we might crash if the input document contains a series of surrogate halves. it might be that the existing fixup makes the same assumption, that if we shift one character we'll not find another lone low or high surrogate. just wanted to point it out. |
michal-kurz
force-pushed
the
setup-npm-pkg
branch
from
0a7be4b to
4fc32c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.