Skip to content

fix: 🐛 failed upload message with direct upload #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2021
Merged

fix: 🐛 failed upload message with direct upload #43

merged 1 commit into from
Sep 14, 2021

Conversation

janbadura
Copy link

Story

  • when uploading file through direct upload, webchat is showing notice that the message wasn't sent successfully
  • was caused by direct upload activity object didn't include id

Fix

  • Added fixed id for direct uploads

@dvorakjan dvorakjan merged commit 4da2841 into feature/skoda Sep 14, 2021
@dvorakjan dvorakjan deleted the feature/error-message-after-direct-upload branch September 14, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvorakjan dvorakjan dvorakjan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janbadura @dvorakjan