Skip to content

Allow creating databases with dashes in the name #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Allow creating databases with dashes in the name #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prepare_database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func defaultCreateDatabase(port uint32, username, password, database string) (er
err = connectionClose(db, err)
}()

if _, err := db.Exec(fmt.Sprintf("CREATE DATABASE %s", database)); err != nil {
if _, err := db.Exec(fmt.Sprintf("CREATE DATABASE \"%s\"", database)); err != nil {
return errorCustomDatabase(database, err)
}

Expand Down
14 changes: 14 additions & 0 deletions prepare_database_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,20 @@ func Test_defaultCreateDatabase_ErrorWhenSQLOpenError(t *testing.T) {
assert.EqualError(t, err, "unable to connect to create database with custom name database with the following error: client_encoding must be absent or 'UTF8'")
}

func Test_defaultCreateDatabase_DashesInName(t *testing.T) {
database := NewDatabase(DefaultConfig().
Port(9832).
Database("my-cool-database"))

if err := database.Start(); err != nil {
t.Fatal(err)
}

if err := database.Stop(); err != nil {
t.Fatal(err)
}
}

func Test_defaultCreateDatabase_ErrorWhenQueryError(t *testing.T) {
database := NewDatabase(DefaultConfig().
Port(9831).
Expand Down