make persistence and path of db data directory configurable #19
Conversation
|
All in all looks like a good start! Couple of comments to look into and we should try to support back to GoLang 1.13 where possible. I'm not 100% sure about checking the PG_VERSION file. You may need to include this coverage in the platform-tests in order to confirm that the logic works across all previous supported versions of Postgres. I think it does but no harm adding coverage. Thanks! |
bearsh
force-pushed
the
feature/dataPath
branch
2 times, most recently
from
a23dd09 to
ca261c5
Compare
|
|
||
| // Start will try to start the configured Postgres process returning an error when there were any problems with invocation. | ||
| // If any error occurs Start will try to also Stop the Postgres process in order to not leave any sub-process running. | ||
| //nolint:funlen |
There was a problem hiding this comment.
Would be great to avoid this but I'll tidy up in a later commit.
|
Looks great. Be awesome if we could avoid dropping coverage but I will resolve this when I run back over and relint all the code in an upcoming release. One last thing before I merge. Could you add some sort of documentation to the README.md and perhaps an example in examples directory. Will aim to merge as soon as these are complete! Thanks |
- config: add field and setter for db data path - do not delete/reinit db data dir if path is set - data dir must exist and the pg (major) version must match used postgres version
I've added a paragraph to the README.md, an example would have to wait, sorry... |
Great. Feel free to open a second PR with this, it would definitely be helpful to our users. |
2 participants
closes: #18