ServiceAuth and NullAuth #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
force-pushed
the
feat/null-auth
branch
from
f333dca to
268c6fd
Compare
aarshkshah1992
approved these changes
May 29, 2025
Contributor
|
Lgtm |
|
|
||
| var _ Auth = (*NullAuth)(nil) | ||
|
|
||
| func (a *NullAuth) AuthService(r *http.Request) (string, error) { |
Contributor
There was a problem hiding this comment.
@ZenGround0 So this means auth always goes through right ? Since error is always nill
ZenGround0
added a commit
that referenced
this pull request
Jun 3, 2025
* ServiceAuth and NullAuth * fix --------- Co-authored-by: zenground0 <[email protected]>
LexLuthr
pushed a commit
that referenced
this pull request
Jul 22, 2025
* ServiceAuth and NullAuth (#512) * ServiceAuth and NullAuth * fix --------- Co-authored-by: zenground0 <[email protected]> * Fix/public service sql mig (#516) * Add sql migration function to enable public service with dummy key * Fix typo --------- Co-authored-by: zenground0 <[email protected]> * Tigher busy waiting (#521) Co-authored-by: zenground0 <[email protected]> * fix (#523) Co-authored-by: zenground0 <[email protected]> * Look in pdp piecerefs to check for actual readiness (#525) * Look in pdp piecerefs to check for actual readiness * fix --------- Co-authored-by: zenground0 <[email protected]> * YOLO (#526) Co-authored-by: zenground0 <[email protected]> * Remove unpadding transformation from root size (#529) Co-authored-by: zenground0 <[email protected]> * feat(pdp): add transaction tracking for root additions (synapse branch) (#530) * feat(pdp): add transaction tracking for root additions - Add Location header to root addition response with tx hash - Add GET /proof-sets/{id}/roots/added/{txHash} endpoint for status checks - Implement handleGetProofSetRoot for retrieving root details - Return confirmed root IDs after transaction confirmation * fix(pdp): use lowercase transaction hashes consistently in database operations * fix(pdp): retain root addition records to prevent 404s on status queries Previously, pdp_proofset_root_adds records were deleted after processing, causing clients to receive 404 errors when querying transaction status after successful root additions. This created a poor UX as clients couldn't verify transaction outcomes if they queried too late. This change aligns root addition tracking with proof set creation by: - Adding roots_added column to mark processed records instead of deleting - Updating watcher to UPDATE instead of DELETE when processing completes - Including roots_added status in API response for client visibility The fix ensures transaction status remains queryable indefinitely while maintaining backward compatibility. Existing records will be processed normally with roots_added=FALSE by default. API enhancement: /pdp/proof-sets/{id}/roots/added/{txHash} now includes "rootsAdded" field indicating if roots were fully processed. * fix(pdp): extra checks to make sure the db entries are consistent * fix(pdp): address review feedback * chore(pdp): add more logging; don't bail early on tx error (#549) * chore(pdp): add transaction processing logging * chore(pdp): tweak logging statements * fix(chain): improve chain scheduler robustness and eth tx monitoring (#553) - Add mutex protection and notification timeout handling to CurioChainSched - Implement timeout protection for eth client calls to prevent indefinite blocking - Add comprehensive test coverage for chain scheduler and eth message watcher - Extract interfaces (EthClient, TaskEngine, EthTransactionManager) for testability * chore(logs): log proof data as hex (#551) --------- Co-authored-by: ZenGround0 <[email protected]> Co-authored-by: zenground0 <[email protected]> Co-authored-by: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor pdp service to take alternate athentication and implement null authentication