Add UI for changing icon and folder type in folder properties

[aolko]

Is your feature request related to a problem? Please describe.
Currently folder icons (via desktop.ini) are not supported, defaulting to a generic folder icon, please add support for them

Describe the solution you'd like
I'd like Files to read desktop.ini inside the folders and apply changes accordingly

Describe alternatives you've considered
An alternative would be doing it the way explorer.exe does

Additional context

[gave92]

Could you post an example desktop.ini containing a custom icon for a folder which doesn't work? Custom icons should be already supported. But the pointed icon must be outside the C:\Windows folder.

[aolko]

Could you post an example desktop.ini containing a custom icon for a folder which doesn't work? Custom icons should be already supported. But the pointed icon must be outside the C:\Windows folder.

[.ShellClassInfo]
IconResource=C:\WINDOWS\System32\SHELL32.dll,299
[ViewState]
Mode=
Vid=
FolderType=Generic

the one from Dummy folder, yes currently i'm using one of shell32 icons. Also Files doesn't detect folder view based on preferences (FolderType, i guess) (Media (large tiles), files (list))

[gave92]

If you try with an icon outside the windows folder it will (should) work. Support for folder type has been added in the development branch (#3526)

[aolko]

If you try with an icon outside the windows folder it will (should) work. Support for folder type has been added in the development branch (#3526)

Yes, non-shell icons do work

Also there's to settings tab in folder preferences, to tweak desktop.ini-based settings, including folder icon, image and type. And preferences shouldn't be maximizable imo.

@ gave92

... Custom icons should be already supported. ...

Really? Where can I find the setting? I couldn't find it in Files 1.3 yet.

[gave92]

@CF-71 you can't change the icon from Files but Files should show any custom icon set from windows explorer.

[yaira2]

Let's continue the conversation over here #1015.