Skip to content

Conversation

@ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Comments

  • I fixed the bug delaying the selection at the end of the timer. This way, the hovered item is selected just before it's opened.
  • There's still a problem with ColumnsLayout, where items have SelectedStyle even when they're not. I believe the bug affects ListViewBase since the code is the same as in GridViewBase, where the feature is working.

Validation
How did you test these changes?

  • Built and ran the app

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 2, 2022
@yaira2 yaira2 merged commit e014c37 into files-community:main Oct 2, 2022
@yaira2 yaira2 changed the title Fixed: Draging files over items select them Fixed: Dragging files over items select them Oct 2, 2022
@ferrariofilippo ferrariofilippo deleted the Fixed_Draging_Files_Select_Hovered_Items_#6768 branch October 6, 2022 19:57
@yaira2
Copy link
Member

yaira2 commented Oct 9, 2022

There's still a problem with ColumnsLayout, where items have SelectedStyle even when they're not. I believe the bug affects ListViewBase since the code is the same as in GridViewBase, where the feature is working

Doesn't DetailsLayout use ListViewBase as well?

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Oct 10, 2022

If you hover over a folder for 1s while dragging an item, Files selects it and opens it.
If you use DetailsLayout this is not a problem, because Files loads a new pane.
With ColumnsLayout, the selected folder is opened in a new pane, but the previous one remains open. The bug happens here.

I post here a video where you can see what I mean. In ColumnsLayout one item is selected (as you can see from SeletectedItems count), but two have the style applied.

1.mp4

@ferrariofilippo
Copy link
Contributor Author

I just found out that you have already tracked this issue in #9594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants