Skip to content

Conversation

@cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Oct 17, 2022

Resolved / Related Issues
Changes the sidebar drives template to match the property menu
Closes #10214.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
tooltip_light
tooltip_dark

before/after
fixbefore
fixafter

@yaira2 yaira2 changed the title New DriveItem tooltip Feature: Improved the tooltip when hovering over drives Oct 19, 2022
@yaira2
Copy link
Member

yaira2 commented Oct 19, 2022

@cinqmilleans thank you for the PR. Can you confirm how were these changes validated?

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Oct 19, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Oct 20, 2022
@yaira2 yaira2 merged commit 4e3b8db into files-community:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Show more drive details when hovering over the sidebar

2 participants