Skip to content

Conversation

@hishitetsu
Copy link
Member

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Details
Sorting and groups can now be selected in ascending or descending, respectively.

Screenshots
image

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Feb 5, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 8, 2023

Can you apply the same to the right click menu in the folder layouts?

@hishitetsu
Copy link
Member Author

I see, I'll try it later.

@hishitetsu
Copy link
Member Author

Done.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Feb 9, 2023
@yaira2 yaira2 merged commit 50e8524 into files-community:main Feb 9, 2023
@hishitetsu hishitetsu deleted the GroupDirection branch February 9, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Groups should follow ascending/descending preference

2 participants