Skip to content

Conversation

@marcelwgn
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Fix issue with tab icon not loading properly Fix: Fixed issue with tab icon not loading properly Feb 16, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab control is pretty again!
LGTM

@yaira2
Copy link
Member

yaira2 commented Feb 16, 2023

@onein528 fyi, this might be useful for Fluent Hub.

@hecksmosis
Copy link
Contributor

hecksmosis commented Feb 16, 2023

Should FilesLauncher be commited?

@yaira2
Copy link
Member

yaira2 commented Feb 16, 2023

We should add to gitignore for the future but it doesn't really matter for this PR.

@hecksmosis
Copy link
Contributor

Should I add it?

@yaira2
Copy link
Member

yaira2 commented Feb 16, 2023

Sure

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 16, 2023
@yaira2 yaira2 merged commit 42bc25f into files-community:main Feb 16, 2023
@0x5bfa
Copy link
Member

0x5bfa commented Feb 17, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Icons are no longer shown on the tab control

4 participants