Skip to content

Fix: Reset items opacity when copying other items #12252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2023
Merged

Fix: Reset items opacity when copying other items #12252

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d108b4
Fix: Reset cut items opacity when copying other items
ferrariofilippo May 1, 2023
29865c0
Address some null warnings
ferrariofilippo May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions src/Files.App/Helpers/UIFilesystemHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,15 @@
// Copyright (c) 2023 Files Community
// Licensed under the MIT License. See the LICENSE.

using CommunityToolkit.Mvvm.DependencyInjection;
using Files.App.Dialogs;
using Files.App.Extensions;
using Files.App.Filesystem;
using Files.App.Filesystem.StorageItems;
using Files.App.Interacts;
using Files.App.ViewModels;
using Files.App.ViewModels.Dialogs;
using Files.Backend.Enums;
using Files.Backend.Extensions;
using Files.Backend.Services;
using Files.Shared;
using Files.Shared.Enums;
using Files.Shared.Extensions;
using Microsoft.Extensions.Logging;
using Microsoft.UI.Xaml.Controls;
using System;
using System.Collections.Concurrent;
using System.IO;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Windows.ApplicationModel.DataTransfer;
using Windows.Storage;
using Windows.System;
Expand Down Expand Up @@ -144,16 +131,19 @@ await associatedInstance.SlimContentPage.SelectedItems.ToList().ParallelForEachA

public static async Task CopyItem(IShellPage associatedInstance)
{
DataPackage dataPackage = new DataPackage()
var dataPackage = new DataPackage()
{
RequestedOperation = DataPackageOperation.Copy
};
ConcurrentBag<IStorageItem> items = new ConcurrentBag<IStorageItem>();
ConcurrentBag<IStorageItem> items = new();

if (associatedInstance.SlimContentPage.IsItemSelected)
if (associatedInstance.SlimContentPage.IsItemSelected &&
associatedInstance.SlimContentPage.SelectedItems is not null)
{
associatedInstance.SlimContentPage.ItemManipulationModel.RefreshItemsOpacity();

var itemsCount = associatedInstance.SlimContentPage.SelectedItems.Count;
PostedStatusBanner banner = itemsCount > 50 ? ongoingTasksViewModel.PostOperationBanner(
var banner = itemsCount > 50 ? ongoingTasksViewModel.PostOperationBanner(
string.Empty,
string.Format("StatusPreparingItemsDetails_Plural".GetLocalizedResource(), itemsCount),
0,
Expand Down