Skip to content

Fix: Fixed issue with viewing folder details #13758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fix: Fixed issue with viewing folder details #13758

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c42b2d7
Fix: Fixed issue with viewing folder details
yaira2 Nov 8, 2023
68cccf0
Update PreviewPaneViewModel.cs
yaira2 Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Files.App/ViewModels/UserControls/PreviewPaneViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,13 +290,17 @@ public async Task UpdateSelectedItemPreviewAsync(bool downloadItem = false)
{
PreviewPaneState = PreviewPaneStates.LoadingPreview;

if (previewSettingsService.ShowPreviewOnly)
if (previewSettingsService.ShowPreviewOnly ||
SelectedItem?.PrimaryItemAttribute == StorageItemTypes.Folder)
{
loadCancellationTokenSource = new CancellationTokenSource();
await LoadPreviewControlAsync(loadCancellationTokenSource.Token, downloadItem);
}
else
{
await LoadBasicPreviewAsync();
return;
Copy link
Member

@hishitetsu hishitetsu Nov 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this trying to fix? I don't think this return changes anything.

Copy link
Member Author

@yaira2 yaira2 Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return wasn't needed in the end, I had to make some other changes in 68cccf0.

Copy link
Member

@hishitetsu hishitetsu Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I missed it.

}
}
catch (Exception e)
{
Expand Down