Skip to content

Some typo and bug fixes #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2020
Merged

Some typo and bug fixes #1447

merged 2 commits into from
Jul 14, 2020

Conversation

@soumyamahunt
Copy link
Contributor

@soumyamahunt soumyamahunt commented Jul 14, 2020

Fixed #1229 and typo for environment variable.

@soumyamahunt soumyamahunt mentioned this pull request Jul 14, 2020
Closed
@ghost ghost added the ready for review Pull requests that are ready for review label Jul 14, 2020
lukeblevins
lukeblevins approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good changes

@lukeblevins lukeblevins added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jul 14, 2020
@yaira2 yaira2 self-requested a review July 14, 2020 18:34
@yaira2 yaira2 merged commit ba0bd5a into files-community:master Jul 14, 2020
@soumyamahunt soumyamahunt deleted the navigationbar-terminal branch July 15, 2020 04:46
@yaira2
Copy link
Member

yaira2 commented Jul 15, 2020

@soumyamahunt I can still reproduce this issue after merging your changes.

@soumyamahunt
Copy link
Contributor Author

soumyamahunt commented Jul 15, 2020

@soumyamahunt I can still reproduce this issue after merging your changes.

Is it happening to all terminal profiles or specific ones, can you provide which terminal profiles are having issues??

@yaira2
Copy link
Member

yaira2 commented Jul 15, 2020

@soumyamahunt I can still reproduce this issue after merging your changes.

Is it happening to all terminal profiles or specific ones, can you provide which terminal profiles are having issues??

I am seeing the issue with all profiles.

@soumyamahunt
Copy link
Contributor Author

soumyamahunt commented Jul 15, 2020

I am seeing the issue with all profiles.

I tried all default profiles and didn't have any issue in them, @duke7553 you having issue with this too??

WGrOqTvtbq

TYIMaCoQs8

aRi0nNsE3h

@yaira2
Copy link
Member

yaira2 commented Jul 16, 2020

@soumyamahunt It seems to be working fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

+1 more reviewer

@lukeblevins lukeblevins lukeblevins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Launching terminal profiles from the navigation bar is not working correctly

3 participants

@soumyamahunt @yaira2 @lukeblevins