Skip to content

Added an icon to indicate if folders are empty #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 2, 2020
Merged

Added an icon to indicate if folders are empty #1614

merged 16 commits into from
Aug 2, 2020

Conversation

@winston-de
Copy link
Contributor

@winston-de winston-de commented Jul 30, 2020

Adds and uses new icon for non-empty folders as shown in issue #1574.

image

@ghost ghost added the ready for review Pull requests that are ready for review label Jul 30, 2020
@winston-de
Copy link
Contributor Author

winston-de commented Jul 30, 2020

@xpoppyx Looks great. I'll update it now.

@winston-de
Copy link
Contributor Author

winston-de commented Jul 31, 2020 •
edited
Loading

@xpoppyx How/where are you getting shortcuts? They don't show for me.

yaira2
yaira2 requested changes Jul 31, 2020
View reviewed changes
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed ready for review Pull requests that are ready for review labels Jul 31, 2020
@yaira2 yaira2 added ready for review Pull requests that are ready for review and removed changes requested Changes are needed for this pull request labels Jul 31, 2020
@winston-de winston-de requested a review from yaira2 July 31, 2020 19:07
@yaira2 yaira2 changed the title Adds new icon for non-empty folders Added an icon to indicate if folders are empty Jul 31, 2020
@yaira2 yaira2 requested a review from tsvietOK July 31, 2020 19:08
@yaira2 yaira2 removed the ready for review Pull requests that are ready for review label Aug 2, 2020
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Aug 2, 2020
@yaira2 yaira2 merged commit aa2a232 into files-community:master Aug 2, 2020
@yaira2 yaira2 mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

+1 more reviewer

@tsvietOK tsvietOK tsvietOK approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@winston-de @tsvietOK @yaira2