Code Quality: Wrap InvokeVerb inside STA #17092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
added
the
ready to merge
0x5bfa
approved these changes
May 4, 2025
Member
0x5bfa
left a comment
0x5bfa
left a comment
There was a problem hiding this comment.
LGTM. This codebase is not AoT safe so thisll be soon retired FYI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wraps
InvokeVerbin an STA thread to fix COM threading issues when unpinning folders from sidebar. Ensures stable shell verb invocation while maintaining UI responsiveness.Test Steps
Verified unpinning stability by: