Skip to content

Show Network locations and shares and add option to map network drives #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Feb 17, 2021
Merged

Show Network locations and shares and add option to map network drives #3295

merged 31 commits into from
Feb 17, 2021

Conversation

@gave92
Copy link
Member

@gave92 gave92 commented Jan 26, 2021 •
edited
Loading

Fixes #1523
Fixes #2932
Fixes #3488
Fixes #3551

Add support for networks shortcuts and places.

Todo:

  • Show icons in ftp shares
  • Add ability to add new mapped drives → dialog opens behind Files window, solution: make our own dialog
  • No possibility to "cancel" loading network places folder → next time
  • Mapped network drives are still shown under "Drives" → I don't want to duplicate the work done here
  • App freezes for a few seconds when clicking a network drive on the sidebar (reading folder layout) → only when the drive is disconnected
  • Fulltrust process doesn't close if disconnected network drives are present → pre-existing issue

Files
image

Explorer
image

@gave92 gave92 changed the title Show Network locations and shares on the sidebar [Test] Show Network locations and shares on the sidebar Jan 26, 2021
@yaira2 yaira2 self-requested a review January 26, 2021 00:50
@gave92 gave92 changed the title [Test] Show Network locations and shares on the sidebar Show Network locations and shares on the sidebar Jan 26, 2021
@gave92 gave92 force-pushed the network_share branch 4 times, most recently from ba660e4 to 18406e8 Compare January 26, 2021 07:46
@gave92 gave92 force-pushed the network_share branch 2 times, most recently from a868d09 to 18899d8 Compare February 7, 2021 23:57
@gave92 gave92 changed the title Show Network locations and shares on the sidebar Show Network locations and shares and add option to map network drives Feb 14, 2021
@gave92 gave92 marked this pull request as ready for review February 14, 2021 13:00
@gave92
Copy link
Member Author

gave92 commented Feb 17, 2021

Hi @yaichenbaum, did you get any chance to test this?

@yaira2
Copy link
Member

yaira2 commented Feb 17, 2021

@gave92 I don't have any network to test with right now.

@gave92
Copy link
Member Author

gave92 commented Feb 17, 2021 •
edited
Loading

@yaichenbaum no problem. As I don't have it either, to test this I've installed 2/3 apps on my android phone to simulate network shares xD ("Server WebDav", "ES File Explorer", "LAN drive")

@yaira2
Copy link
Member

yaira2 commented Feb 17, 2021

@yaichenbaum no problem. As I don't have it either, to test this I've installed 2/3 apps on my android phone to simulate network shares xD ("Server WebDav", "ES File Explorer", "LAN drive")

Good idea! By the way, how can I map a new drive from Files?

@gave92
Copy link
Member Author

gave92 commented Feb 17, 2021 •
edited
Loading

@yaichenbaum you should find a more menu on the homepage next to the drives header ("...")
Currently it will open the windows dialog for mapping a network drive (probably behind the Files window!)

@yaira2
Copy link
Member

yaira2 commented Feb 17, 2021

@yaichenbaum you should find a more menu on the homepage next to the drives header ("...")
Currently it will open the windows dialog for mapping a network drive (probably behind the Files window!)

I see it now, and yeah, that bug with the window opening behind Files is getting to be pretty bad.

yaira2
yaira2 requested changes Feb 17, 2021
View reviewed changes
@gave92 gave92 requested a review from yaira2 February 17, 2021 22:01
@gave92
Copy link
Member Author

gave92 commented Feb 17, 2021 •
edited
Loading

I see it now, and yeah, that bug with the window opening behind Files is getting to be pretty bad.

Changes done! Regarding the issue of the dialog opening behind Files I'm not too worried as I'm planning to ship our own dialog in a future PR. Thankfully I'm not experiencing the same bug when opening files.

yaira2
yaira2 approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! And thank you for fixing all those random issues.

:shipit:

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 17, 2021
@yaira2 yaira2 merged commit 7b1e066 into files-community:main Feb 17, 2021
This was referenced Feb 17, 2021
Closed
Closed
Closed
@gave92 gave92 deleted the network_share branch February 18, 2021 06:37
@gave92 gave92 mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

2 participants

@gave92 @yaira2