Skip to content

Conversation

@SHADOW-XIII
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Fixed the number of days comparison.
  • If the difference is 7 then it was modified 8 days ago. If the difference is 14 then it was modified 15 days ago.
  • Therefore "This week" is difference of 6 days or less and "Last week" is difference of 13 or less (between 7 to 13 inclusive)

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Fix for #6897 - the difference between "now and 7 days ago" is 6 and between "now and 14 days ago" is 13.
If the difference is 7 then it was modified 8 days ago
If the difference is 14 then it was modified 15 days ago
Copy link
Member

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d2dyno1 d2dyno1 added the ready to merge Pull requests that are approved and ready to merge label Nov 13, 2021
@yaira2 yaira2 requested a review from winston-de November 14, 2021 00:58
@yaira2 yaira2 added ready for review Pull requests that are ready for review and removed ready to merge Pull requests that are approved and ready to merge labels Nov 14, 2021
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 14, 2021
@yaira2 yaira2 merged commit d320a48 into files-community:main Nov 14, 2021
@yaira2
Copy link
Member

yaira2 commented Nov 14, 2021

@SHADOW-XIII thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date grouping "last week" includes a file from 2 weeks ago

3 participants