Skip to content

Fix file extension being lost when renaming, fixes for search #7015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2021
Merged

Fix file extension being lost when renaming, fixes for search #7015

merged 4 commits into from
Nov 22, 2021

Conversation

@gave92
Copy link
Member

@gave92 gave92 commented Nov 21, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Fixes an issue where file extension is lost when renaming a shortcut to a folder
  • Adds an ItemNameRaw property to ListedItem, moves the logic to get the "Display" name from the raw name into ListedItem and subclasses.
  • Fixes an issue where file extensions where shown in Search result page regardless of the "show file extensions" setting
  • Fixes an issue where search results were loaded twice when submitting search
  • Fixes an issue where a file with a random name shows when search yields no results

Validation
How did you test these changes?

  • Built and ran the app
  • Tested renaming files and shortcuts changing the "show file extensions" setting

@gave92 gave92 requested a review from d2dyno1 November 21, 2021 20:20
@gave92 gave92 added the ready for review Pull requests that are ready for review label Nov 21, 2021
@gave92 gave92 changed the title Fix file extension being lost when renaming a shortcut to a folder Fix file extension being lost when renaming, fixes for search Nov 21, 2021
d2dyno1
d2dyno1 reviewed Nov 22, 2021
View reviewed changes
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 22, 2021
@yaira2 yaira2 merged commit 5ee29ff into files-community:main Nov 22, 2021
This was referenced Nov 22, 2021
Closed
Closed
@gave92 gave92 deleted the issue_7012 branch November 22, 2021 21:21
@gave92 gave92 restored the issue_7012 branch November 23, 2021 03:34
@gave92 gave92 deleted the issue_7012 branch November 23, 2021 03:37
@gave92 gave92 mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@d2dyno1 d2dyno1 d2dyno1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When I rename a shortcut of a folder, it is no longer a shortcut file Renaming issue on search results

3 participants

@gave92 @d2dyno1 @yaira2