Skip to content

feat: Extend DetailsLayout editing element width #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 5, 2022
Merged

feat: Extend DetailsLayout editing element width #7445

merged 7 commits into from
Jan 5, 2022

Conversation

@lukeblevins
Copy link
Contributor

@lukeblevins lukeblevins commented Jan 4, 2022

Resolved / Related Issues

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
image

@lukeblevins lukeblevins requested a review from yaira2 January 4, 2022 18:33
yaira2
yaira2 reviewed Jan 4, 2022
View reviewed changes
yaira2
yaira2 requested changes Jan 4, 2022
View reviewed changes
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Jan 4, 2022
@yaira2 yaira2 requested a review from gave92 January 5, 2022 00:41
@yaira2 yaira2 self-requested a review January 5, 2022 17:05
@yaira2 yaira2 added ready for review Pull requests that are ready for review and removed changes requested Changes are needed for this pull request labels Jan 5, 2022
yaira2
yaira2 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jan 5, 2022
@yaira2 yaira2 merged commit d2f14aa into main Jan 5, 2022
@yaira2 yaira2 deleted the dev/lubl/dv-span-editingel branch January 5, 2022 17:36
@yaira2 yaira2 mentioned this pull request Jan 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

+1 more reviewer

@gave92 gave92 gave92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

File Renaming UX Improvement

4 participants

@lukeblevins @gave92 @yaira2