Skip to content

Conversation

@DavidPerikala
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • So far, we have assumed the OS directory to be "C:"
  • Fixed by using %systemroot% env path to get the OS root directory

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 self-requested a review August 17, 2022 14:56
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Aug 17, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Aug 17, 2022
@yaira2 yaira2 merged commit 8908a5b into files-community:main Aug 17, 2022
@DavidPerikala DavidPerikala deleted the 9307_Fix-Hardcoded-OS-Path branch August 17, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Customization page doesn't have the correct path

2 participants