Skip to content

Fix localized strings appearing empty in Compatibility properties #9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fix localized strings appearing empty in Compatibility properties #9868

merged 1 commit into from
Aug 31, 2022

Conversation

@gave92
Copy link
Member

@gave92 gave92 commented Aug 31, 2022 •
edited
Loading

Details of Changes
Add details of changes here.

  • Fix the GetLocalizedResource() method to return empty string instead of throwing exception when the string resource is not found. This was the behavior on UWP and some code relies on this.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented Aug 31, 2022

Can we log the exception in app center so that we know to fix it?

@gave92
Copy link
Member Author

gave92 commented Aug 31, 2022

There's no exception to log :)

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Aug 31, 2022
@yaira2 yaira2 merged commit b8bcf67 into files-community:main Aug 31, 2022
@gave92 gave92 deleted the resloader branch August 31, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gave92 @yaira2