Fix Race Conditions in File Operations #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @vijaykrishnavanshi and @nadeem-fileverse, when you have time please to look at this micro PR, and possibly the other small PRs, when possible. |
…tions and unify the file name convention
- call `await this.smartAccountClient.waitForUserOperationReceipt({ hash })`; at `update` and `delete` similar to how it is called in create. This is to prevent race conditions, if more edit operations where performed immediately after update or delete.
- at `update` use the same naming convention used at `create` for file names (`${this.portal.portalAddress}/${this.namespace}/${filename}`).
Muhammad-Altabba
force-pushed
the
fix/wait-for-user-operation-receipts
branch
from
b68aafb to
9de68a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Changes
Added
waitForUserOperationReceipt()calls inupdate()anddelete()methods to ensure transactions are confirmed on-chain before proceeding with other operations.This standardizes transaction handling across all CRUD operations to match the pattern already used in
create().This PR is based on #9 that is the best to be reviewed and merged first. As, this PR has just 2 commits. The first commit contains the changes of #9, and the second commit is the actual work that fixes #13