Failing test case for calling DataSnapshot methods with null values #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhodgkins
added a commit
to rhodgkins/firebase-functions
that referenced
this pull request
Jan 13, 2025
rhodgkins
added a commit
to rhodgkins/firebase-functions
that referenced
this pull request
Feb 4, 2025
github-merge-queue bot
pushed a commit
to firebase/firebase-functions
that referenced
this pull request
Oct 8, 2025
* Fixed issue calling DataSnapshot methods with null data (see firebase/firebase-functions-test#254) * Added test cases for fix * Better fix for calling DataSnapshot#val() with null data * Add changelog. --------- Co-authored-by: Daniel Lee <[email protected]> Co-authored-by: Daniel Lee <[email protected]>
github-project-automation
bot
moved this from Review Requested [PR]
to Done
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you've created a
DataSnapshotwith anullvalue, you should be able to call methods on that object.Will be fixed with an incoming upstream fix in
firebase-functions.Code sample
See commit