Skip to content

Firestore Spec Tests: Port JS PR 7021 (bundle the readTime and resumeToken) #11183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2023
Merged

Firestore Spec Tests: Port JS PR 7021 (bundle the readTime and resumeToken) #11183

merged 2 commits into from
Apr 26, 2023

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Apr 25, 2023 •
edited
Loading

Port spec test changes from firebase/firebase-js-sdk#7021 (Bundle the readTime and resumeToken into a data structure)

For reference, here is the Android port of the same change: firebase/firebase-android-sdk#4928

#no-changelog

@dconeybe dconeybe self-assigned this Apr 25, 2023
@dconeybe dconeybe mentioned this pull request Apr 25, 2023
Merged
@google-oss-bot
Copy link

google-oss-bot commented Apr 25, 2023

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 87.99% (483ccd3) to 88.05% (77b06ab) by +0.05%.

    FilenameBase (483ccd3)Merge (77b06ab)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc98.82%98.14%-0.69%
    leveldb_remote_document_cache.cc96.41%94.61%-1.80%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ll4k8fanjW.html

@dconeybe dconeybe mentioned this pull request Apr 26, 2023
Merged
@dconeybe dconeybe merged commit 82f2534 into master Apr 26, 2023
@dconeybe dconeybe deleted the dconeybe/SpecTestPortJsSdkPr7021 branch April 26, 2023 18:22
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

Assignees

@dconeybe dconeybe

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dconeybe @google-oss-bot @cherylEnkidu