Adds and modifies deprecation messages #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
May 1, 2018
| (nullable FIRAuthDataResultCallback)completion | ||
| DEPRECATED_MSG_ATTRIBUTE("signInAnonymouslyAndRetrieveDataWithCompletion: is deprecated." | ||
| " Please use signInAnonymouslyWithCompletion: for Objective-C or" | ||
| DEPRECATED_MSG_ATTRIBUTE(" Please use signInAnonymouslyWithCompletion: for Objective-C or" |
paulb777
pushed a commit
that referenced
this pull request
May 1, 2018
* Adds and modifies deprecation messages * Addresses Comments
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Adds and modifies deprecation messages * Addresses Comments
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Adds and modifies deprecation messages * Addresses Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deprecation messages for linkWithCredential:completion and reauthenicateWithCredential:completion:
Also corrects the deprecation messages for other deprecated APIs where part of the message was being repeated.