Skip to content

Add IndexConfiguration CRUD to IndexManager #9348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 18, 2022
Merged

Add IndexConfiguration CRUD to IndexManager #9348

merged 11 commits into from
Feb 18, 2022

Conversation

@wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Feb 15, 2022 •
edited
Loading

#no-changelog

@wu-hui
Add index.proto
6ab9abc
@wu-hui
temp commit
6e079c8
@wu-hui
Configureation CRUD.
1b60b0f
@wu-hui
Merge branch 'master' into wuandy/IndexManager
0790056 
# Conflicts:
#	Firestore/Example/Firestore.xcodeproj/project.pbxproj
#	Firestore/core/src/local/leveldb_key.cc
@wu-hui wu-hui self-assigned this Feb 15, 2022
@wu-hui wu-hui closed this Feb 15, 2022
@wu-hui wu-hui reopened this Feb 15, 2022
@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Feb 15, 2022
@google-oss-bot
Copy link

google-oss-bot commented Feb 15, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (8dae747)Merge (6489504)Diff
    CocoaPods4.95 MB5.00 MB+52.0 kB (+1.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8087EUM1Ih.html

@google-oss-bot
Copy link

google-oss-bot commented Feb 15, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from ? (8dae747) to 86.00% (6489504) by ?.

    206 individual files with coverage change

    FilenameBase (8dae747)Merge (6489504)Diff
    any.nanopb.cc?0.00%?
    array_contains_any_filter.cc?100.00%?
    array_contains_filter.cc?100.00%?
    async_queue.cc?100.00%?
    auth_token.cc?100.00%?
    autoid.cc?100.00%?
    background_queue.cc?100.00%?
    bits.cc?100.00%?
    bound.cc?81.03%?
    bundle.nanopb.cc?0.00%?
    bundle_loader.cc?95.65%?
    bundle_reader.cc?90.29%?
    bundle_serializer.cc?91.84%?
    byte_stream_apple.mm?86.36%?
    byte_stream_cpp.cc?83.33%?
    byte_string.cc?80.30%?
    collection_reference.cc?100.00%?
    common.nanopb.cc?33.33%?
    comparison.cc?100.00%?
    connectivity_monitor.cc?100.00%?
    connectivity_monitor_apple.mm?51.92%?
    converters.mm?100.00%?
    database_id.cc?65.38%?
    database_info.cc?100.00%?
    datastore.cc?96.63%?
    delete_mutation.cc?86.36%?
    direction.cc?76.92%?
    document.cc?0.00%?
    document.nanopb.cc?94.78%?
    document_change.cc?62.50%?
    document_key.cc?95.31%?
    document_key_reference.cc?65.00%?
    document_reference.cc?100.00%?
    document_set.cc?87.30%?
    document_snapshot.cc?100.00%?
    empty.nanopb.cc?0.00%?
    error_apple.mm?92.31%?
    event_manager.cc?98.08%?
    exception.cc?23.68%?
    exception_apple.mm?89.66%?
    executor_libdispatch.mm?97.54%?
    executor_std.cc?97.71%?
    exponential_backoff.cc?100.00%?
    field_filter.cc?88.39%?
    field_index.cc?66.25%?
    field_mask.cc?100.00%?
    field_path.cc?98.16%?
    field_transform.cc?41.67%?
    filesystem_apple.mm?77.78%?
    filesystem_common.cc?81.67%?
    filesystem_posix.cc?81.82%?
    filter.cc?50.00%?
    FIRCollectionReference.mm?95.08%?
    FIRDocumentChange.mm?73.68%?
    FIRDocumentReference.mm?97.10%?
    FIRDocumentSnapshot.mm?96.84%?
    firebase_app_check_credentials_provider_apple.mm?92.93%?
    firebase_auth_credentials_provider_apple.mm?75.91%?
    firebase_metadata_provider_apple.mm?100.00%?
    firebase_metadata_provider_noop.cc?100.00%?
    firestore.cc?95.00%?
    firestore.nanopb.cc?37.12%?
    firestore_client.cc?98.57%?
    firestore_index_value_writer.cc?0.00%?
    FIRFieldPath.mm?82.93%?
    FIRFieldValue.mm?89.41%?
    FIRFirestore.mm?90.69%?
    FIRFirestoreSettings.mm?84.21%?
    FIRFirestoreSource.mm?72.73%?
    FIRGeoPoint.mm?82.22%?
    FIRListenerRegistration.mm?100.00%?
    FIRLoadBundleTask.mm?80.70%?
    FIRQuery.mm?87.64%?
    FIRQuerySnapshot.mm?95.45%?
    FIRSnapshotMetadata.mm?100.00%?
    FIRTimestamp.m?79.35%?
    FIRTransaction.mm?96.85%?
    FIRWriteBatch.mm?100.00%?
    FSTFirestoreComponent.mm?97.83%?
    FSTUserDataReader.mm?94.36%?
    FSTUserDataWriter.mm?84.34%?
    geo_point.cc?65.00%?
    grpc_completion.cc?100.00%?
    grpc_connection.cc?76.79%?
    grpc_nanopb.cc?94.87%?
    grpc_root_certificate_finder_generated.cc?100.00%?
    grpc_stream.cc?99.01%?
    grpc_streaming_reader.cc?100.00%?
    grpc_unary_call.cc?100.00%?
    grpc_util.cc?100.00%?
    hard_assert.cc?100.00%?
    http.nanopb.cc?0.00%?
    index.nanopb.cc?0.00%?
    index_entry.cc?0.00%?
    in_filter.cc?100.00%?
    key_field_filter.cc?100.00%?
    key_field_in_filter.cc?100.00%?
    key_field_not_in_filter.cc?100.00%?
    latlng.nanopb.cc?76.92%?
    leveldb_bundle_cache.cc?76.00%?
    leveldb_document_overlay_cache.cc?0.00%?
    leveldb_index_manager.cc?63.93%?
    leveldb_key.cc?98.58%?
    leveldb_lru_reference_delegate.cc?94.31%?
    leveldb_migrations.cc?92.31%?
    leveldb_mutation_queue.cc?92.08%?
    leveldb_opener.cc?76.81%?
    leveldb_persistence.cc?86.08%?
    leveldb_remote_document_cache.cc?94.58%?
    leveldb_target_cache.cc?94.33%?
    leveldb_transaction.cc?98.11%?
    leveldb_util.cc?71.43%?
    load_bundle_task.cc?97.06%?
    local_documents_view.cc?100.00%?
    local_serializer.cc?83.19%?
    local_store.cc?100.00%?
    local_view_changes.cc?100.00%?
    log_apple.mm?93.33%?
    lru_garbage_collector.cc?91.34%?
    maybe_document.nanopb.cc?28.57%?
    memory_bundle_cache.cc?100.00%?
    memory_document_overlay_cache.cc?100.00%?
    memory_eager_reference_delegate.cc?100.00%?
    memory_index_manager.cc?41.38%?
    memory_lru_reference_delegate.cc?95.41%?
    memory_mutation_queue.cc?98.18%?
    memory_persistence.cc?95.65%?
    memory_remote_document_cache.cc?100.00%?
    memory_target_cache.cc?100.00%?
    message.cc?100.00%?
    mutable_document.cc?64.49%?
    mutation.cc?88.17%?
    mutation.nanopb.cc?74.19%?
    mutation_batch.cc?86.89%?
    mutation_batch_result.cc?52.17%?
    nanopb_util.cc?100.00%?
    not_in_filter.cc?100.00%?
    object_value.cc?100.00%?
    online_state_tracker.cc?100.00%?
    ordered_code.cc?94.15%?
    order_by.cc?50.00%?
    overlay.cc?100.00%?
    patch_mutation.cc?100.00%?
    path.cc?100.00%?
    precondition.cc?75.68%?
    pretty_printing.cc?83.33%?
    proto_sizer.cc?72.73%?
    query.cc?97.57%?
    query.nanopb.cc?82.24%?
    query_core.cc?95.65%?
    query_engine.cc?96.49%?
    query_listener.cc?100.00%?
    query_listener_registration.cc?100.00%?
    query_snapshot.cc?83.16%?
    reader.cc?100.00%?
    reference_set.cc?88.89%?
    remote_event.cc?96.38%?
    remote_objc_bridge.cc?90.23%?
    remote_store.cc?90.35%?
    resource.nanopb.cc?0.00%?
    resource_path.cc?100.00%?
    schedule.cc?100.00%?
    secure_random_arc4random.cc?100.00%?
    serializer.cc?87.11%?
    server_timestamp_util.cc?97.06%?
    settings.cc?0.00%?
    set_mutation.cc?89.36%?
    snapshots_in_sync_listener_registration.cc?100.00%?
    snapshot_metadata.cc?100.00%?
    snapshot_version.cc?83.33%?
    status.cc?73.05%?
    status.nanopb.cc?68.75%?
    statusor.cc?80.00%?
    status_apple.mm?96.61%?
    status_errno.cc?30.25%?
    stream.cc?98.44%?
    strerror.cc?100.00%?
    string_apple.cc?100.00%?
    string_format.cc?93.94%?
    string_util.cc?100.00%?
    struct.nanopb.cc?5.06%?
    sync_engine.cc?95.20%?
    target.cc?93.62%?
    target.nanopb.cc?45.95%?
    target_data.cc?40.63%?
    target_id_generator.cc?100.00%?
    task.cc?94.78%?
    timestamp.cc?94.00%?
    timestamp.nanopb.cc?100.00%?
    timestamp_internal.cc?53.33%?
    transaction.cc?89.17%?
    transaction_runner.cc?100.00%?
    transform_operation.cc?76.13%?
    user.cc?100.00%?
    user_data.cc?96.30%?
    value_util.cc?93.58%?
    verify_mutation.cc?13.33%?
    view.cc?97.56%?
    view_snapshot.cc?76.92%?
    watch_change.cc?83.33%?
    watch_stream.cc?90.70%?
    wrappers.nanopb.cc?8.33%?
    write.nanopb.cc?60.25%?
    writer.cc?96.97%?
    write_batch.cc?91.89%?
    write_stream.cc?90.14%?

  • FirebaseFirestore-iOS-FirebaseFirestoreSwift.framework

    Overall coverage changed from ? (8dae747) to 47.02% (6489504) by ?.

    20 individual files with coverage change

    FilenameBase (8dae747)Merge (6489504)Diff
    CodablePassThroughTypes.swift?100.00%?
    CollectionReference+AsyncAwait.swift?93.75%?
    CollectionReference+WriteEncodable.swift?100.00%?
    DocumentID.swift?80.00%?
    DocumentReference+Codable.swift?50.00%?
    DocumentReference+WriteEncodable.swift?100.00%?
    DocumentSnapshot+ReadDecodable.swift?75.00%?
    ExplicitNull.swift?90.48%?
    FieldValue+Encodable.swift?100.00%?
    Firestore+AsyncAwait.swift?96.67%?
    FirestoreDecoder.swift?45.89%?
    FirestoreEncoder.swift?60.41%?
    FirestoreQuery.swift?0.00%?
    FirestoreQueryObservable.swift?0.00%?
    GeoPoint+Codable.swift?100.00%?
    QueryPredicate.swift?0.00%?
    ServerTimestamp.swift?96.97%?
    Timestamp+Codable.swift?100.00%?
    Transaction+WriteEncodable.swift?100.00%?
    WriteBatch+WriteEncodable.swift?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HoMxPoTIb0.html

schmidt-sebastian
schmidt-sebastian reviewed Feb 15, 2022
View reviewed changes
@wu-hui wu-hui assigned wu-hui and unassigned schmidt-sebastian Feb 16, 2022
@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Feb 17, 2022
schmidt-sebastian
schmidt-sebastian approved these changes Feb 18, 2022
View reviewed changes
@wu-hui wu-hui merged commit 47c046e into master Feb 18, 2022
@wu-hui wu-hui deleted the wuandy/IndexManager branch February 18, 2022 18:34
ncooke3
ncooke3 reviewed Mar 8, 2022
View reviewed changes
Firestore/core/src/local/local_serializer.cc
Comment on lines +501 to +503
result->fields_count = segments.size();
result->fields =
MakeArray<google_firestore_admin_v1_Index_IndexField>(segments.size());
Copy link
Member

@ncooke3 ncooke3 Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these new lines caused a few warnings. Reported in #9430

Copy link
Member

@ncooke3 ncooke3 Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @wu-hui

Copy link
Contributor

@dconeybe dconeybe Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reporting this. #9433 fixes the warnings.

@firebase firebase locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ncooke3 ncooke3 ncooke3 left review comments

@dconeybe dconeybe dconeybe left review comments

+1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wu-hui wu-hui

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wu-hui @google-oss-bot @schmidt-sebastian @ncooke3 @dconeybe