-
Notifications
You must be signed in to change notification settings - Fork 987
feat!(ai): add support for anyOf schemas
#9042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: Makes `type` optional on `SchemaRequest`, `SchemaInterface`.
Changeset File Check ✅
|
🦋 Changeset detectedLatest commit: 94b159d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
hsubox76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid I might have caused a merge conflict by merging #8948 - the only file it is complaining about is a test but since it touches the handling of optionalProperties maybe double check it doesn't break anything else.
egilmorez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG except for an apparent issue with a link, PTAL.
egilmorez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seeing a handful of what appear to be "missing links." :)
Called out each instance.
egilmorez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
BREAKING CHANGE: Makes
typeoptional onSchemaRequest,SchemaInterface.Do not merge until v12 release
For context, see firebase/firebase-ios-sdk#14647