Skip to content

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Oct 6, 2025

Description

Add support for Firestore Database Clone

Scenarios Tested

  • Clone database without specifying timestamp
  • Clone database with specified timestamp
  • Clone to database that already exists (error)
  • Clone to database with explicit Google-default encryption
  • Clone to database with explicit keep-the-same-encryption config (the default)
  • Clone to database with explicitly chosen KMS key
  • Specify KMS key without explicitly choosing CMEK encryption (error)
  • Specify customer-managed encryption without picking a CMEK key (error)

Sample Commands

  • firebase firestore:databases:clone projects/myproject/databases/original-db projects/myproject/databases/clone (chooses most recent available snapshot)
  • firebase firestore:databases:clone projects/myproject/databases/original-db projects/myproject/databases/clone2 --snapshot-time 2025-10-06T10:00:00Z (uses selected snapshot time)
  • firebase firestore:databases:clone projects/myproject/databases/original-db projects/myproject/databases/db-with-same-encryption --snapshot-time 2025-10-06T10:00:00Z --encryption-type USE_SOURCE_ENCRYPTION
  • firebase firestore:databases:clone projects/myproject/databases/original-db projects/myproject/databases/db-with-kms-encryption --snapshot-time 2025-10-06T10:00:00Z --encryption-type CUSTOMER_MANAGED_ENCRYPTION --kms-key-name projects/myproject/locations/us-central1/keyRings/testkeyring/cryptoKeys/k1
  • firebase firestore:databases:clone projects/myproject/databases/original-db projects/myproject/databases/db-with-google-managed-encryption --snapshot-time 2025-10-06T10:00:00Z --encryption-type GOOGLE_DEFAULT_ENCRYPTION

@rwhogg rwhogg marked this pull request as ready for review October 6, 2025 15:39
@rwhogg rwhogg force-pushed the rh-firestore-clone branch 3 times, most recently from 224e9f8 to 9bb892b Compare October 7, 2025 13:38
@rwhogg rwhogg requested a review from joehan October 7, 2025 13:39
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and suggestions, but this mostly lgtm

@rwhogg rwhogg force-pushed the rh-firestore-clone branch from 9bb892b to 7acd3bc Compare October 7, 2025 19:58
@rwhogg rwhogg requested a review from joehan October 7, 2025 19:59
@rwhogg rwhogg force-pushed the rh-firestore-clone branch from 7acd3bc to 983e3e7 Compare October 7, 2025 20:05
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a CHANGELOG entry, but LGTM otherwise

@rwhogg rwhogg force-pushed the rh-firestore-clone branch from 983e3e7 to 448581b Compare October 16, 2025 20:00
@rwhogg rwhogg enabled auto-merge (squash) October 16, 2025 20:01
@rwhogg rwhogg force-pushed the rh-firestore-clone branch from 448581b to c9c2fd0 Compare October 16, 2025 20:08
@rwhogg rwhogg force-pushed the rh-firestore-clone branch from e08d490 to 4b58144 Compare October 17, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants