Make fields in TestDeviceSchema required

[tagboola]

Description

The build was failing with the following error

Error: src/mcp/tools/apptesting/tests.ts(50,9): error TS2345: Argument of type '{ version?: string; locale?: string; model?: string; orientation?: "portrait" | "landscape"; }[]' is not assignable to parameter of type 'TestDevice[]'.
  Type '{ version?: string; locale?: string; model?: string; orientation?: "portrait" | "landscape"; }' is not assignable to type 'TestDevice'.
    Property 'model' is optional in type '{ version?: string; locale?: string; model?: string; orientation?: "portrait" | "landscape"; }' but required in type 'TestDevice'.

So I made all the fields in TestDeviceSchema required.

Scenarios Tested

Sample Commands

[gemini-code-assist]

Summary of Changes

Hello @tagboola, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential error by refining the schema definition for TestDevice within the application testing tools. By transitioning from an explicit object definition to leveraging z.custom with an imported TestDevice type, the change aims to enhance type consistency and prevent validation issues, ensuring that the TestDevice schema accurately reflects its intended structure.

Highlights

• Schema Definition Refinement: The TestDeviceSchema in src/mcp/tools/apptesting/tests.ts has been updated to utilize z.custom<TestDevice>(). This change replaces an inline z.object definition, aligning the schema with the canonical TestDevice type imported from ../../../appdistribution/types.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an error by changing the Zod schema for TestDevice. It replaces a z.object with z.custom<TestDevice>(). While this fixes the type conflict that likely caused the error, it also removes validation of the object's structure. My review includes a suggestion to use a corrected z.object schema instead. This approach maintains type safety and validation, which is important when dealing with data from external sources.