Remove overrides that diverge the test configuration from the build c…

[jrothfeder]

…onfiguration.

Description

Confusing, spurious error in https://github.com/firebase/firebase-tools/pull/9280/files

Error: src/mcp/tools/apptesting/tests.ts(50,9): error TS2345: Argument of type '{ version?: string; locale?: string; model?: string; orientation?: "portrait" | "landscape"; }[]' is not assignable to parameter of type 'TestDevice[]'.
  Type '{ version?: string; locale?: string; model?: string; orientation?: "portrait" | "landscape"; }' is not assignable to type 'TestDevice'.
    Property 'model' is optional in type '{ version?: string; locale?: string; model?: string; orientation?: "portrait" | "landscape"; }' but required in type 'TestDevice'.

was encountered when running npm run test but not for npm run build. The reason for this appears to be a side effect of zod inference which is addressed by ensuring that strict=true (see https://stackoverflow.com/questions/71185664/why-does-zod-make-all-my-schema-fields-optional).

Tradeoff here is that js files cannot be checked with strict=true because the complier appears to treat js as ts. However, I think we're better off with the test config being aligned with the build config especially given that our MCP server uses zod implicitly.

[gemini-code-assist]

Summary of Changes

Hello @jrothfeder, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a discrepancy between the test and build configurations that led to a TypeScript compilation error during testing, specifically related to zod type inference. By removing specific overrides in tsconfig.compile.json, the change ensures that strict TypeScript checking is consistently applied, aligning the test configuration with the build configuration's strictness. This change prioritizes robust TypeScript type safety over JavaScript file checking in this particular compilation context.

Highlights

• TypeScript Strict Mode: Removed strict: false and related strictness overrides from tsconfig.compile.json, allowing the configuration to inherit the default strict mode (likely true) from the base tsconfig.json. This resolves a zod inference error encountered during testing.
• JavaScript Checking: Disabled checkJs: true in tsconfig.compile.json to prioritize strict TypeScript checking. The rationale is that enabling strict mode for TypeScript is more beneficial than checking JavaScript files, which the compiler might treat as TypeScript.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes several TypeScript compiler option overrides from tsconfig.compile.json to align it with the base tsconfig.json. This correctly enables strict mode, which resolves a type inference issue with zod, at the cost of no longer type-checking JavaScript files. The change is well-reasoned, simplifies the configuration, and I see no issues with the proposed changes.