-
Notifications
You must be signed in to change notification settings - Fork 274
FirebaseServerApp #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FirebaseServerApp #366
Conversation
DellaBitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have changes to the client service worker, too?
|
@DellaBitta no changes strictly needed as the current code in |
|
Got it, thanks! |
egilmorez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits from the related CL, thanks James!
egilmorez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
auth/service-worker-sessions.jsSimplify the SW codewill do this in a follow on@ts-expect-errorwhen api has landedThere is no compat version of this API.
API proposal: go/fb-web-firebaseserverapp
WIP impl: firebase/firebase-js-sdk#8005
WIP docs: cl/607423524
Trying to keep it simple for now, matching the behavior of the current Admin SDK snippet in the docs—which wasn't in this repo, addressing here.
Existing snippets:
auth(-next)/server-worker-sessions.jsauth_svc_registerauth_svc_sign_in_emailauth_svc_listen_activateauth_svc_interceptauth_svc_subscribeauth_svc_get_idtokenNew snippets:
auth/server-worker-sessions.jsauth_svc_adminfirebaseserverapp-next/firebaseserverapp.jsserverapp_auth