Fix InitrdPath usage #295
Merged
Fix InitrdPath usage #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I wonder if having a root drive is at odds with an initrd. As in: you can't have a root drive if you have an initrd. |
|
Anyone want to look into this? |
|
Hey. Sorry for the late reply. We've fixed the Go 1.11 issue on master. Could you rebase this branch? |
initrdFilename was always blank because it wasn't assigned w the right scope. don't need to validate that a root drive is present when an InitrdPath is present Signed-off-by: Jerome Gravel-Niquet <[email protected]>
|
Looks good to me. Can you remove |
|
My bad, I wanted to make all the tests pass. Looks like another one is failing in the firecracker suite. |
|
Yes. There were a few root-owned files which BuildKite Agent couldn't remove. |
kzys
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The way
InitrdPathwas implemented is buggy:initrd_pathwith firecracker, you do not want a root drive.initrdFilenameto ever be set to anything other than"". This would make the config forInitrdPathuseless.With both these changes, I was able to use
initrd_pathsuccessfully.