Skip to content

Conversation

kzys
Copy link
Contributor

@kzys kzys commented May 4, 2022

This commit removes the package with the help of
https://github.com/xdg-go/go-rewrap-errors.

fmt.Errorf() can wrap errors nowadays.

Signed-off-by: Kazuyoshi Kato [email protected]

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kzys kzys requested a review from a team as a code owner May 4, 2022 17:40
This commit removes the package with the help of
https://github.com/xdg-go/go-rewrap-errors.

fmt.Errorf() can wrap errors nowadays.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys kzys force-pushed the no-pkg-errors branch from 05bf59a to 534d566 Compare May 4, 2022 17:44
github.com/google/uuid v1.3.0
github.com/hashicorp/go-multierror v1.1.1
github.com/mdlayher/vsock v1.1.1
github.com/pkg/errors v0.9.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this not affect go.sum?

Copy link
Contributor Author

@kzys kzys May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since our transitive dependencies are still using pkg/errors, yes. Go still needs to record the information about the package in go.sum.

@kzys kzys merged commit f0a967e into firecracker-microvm:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants