Added API functionality + testing to get Firecracker Version #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
reviewed
Jun 15, 2022
kzys
reviewed
Jun 15, 2022
sondavidb
force-pushed
the
firecracker-version
branch
from
80906c0 to
eddc6fb
Compare
kzys
reviewed
Jun 15, 2022
sondavidb
force-pushed
the
firecracker-version
branch
6 times, most recently
from
c405491 to
075edcb
Compare
austinvazquez
approved these changes
Jun 16, 2022
sondavidb
force-pushed
the
firecracker-version
branch
from
075edcb to
9249819
Compare
sondavidb
force-pushed
the
firecracker-version
branch
from
9249819 to
15c0579
Compare
Signed-off-by: David Son <[email protected]>
sondavidb
force-pushed
the
firecracker-version
branch
from
15c0579 to
a1fdd61
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability for users to get the current version of Firecracker being used, and added tests in both firecracker_test.go and machine_test.go.
Functions were added in where it made some logical sense to me. If it's not consistent with the overall structure please let me know, as I couldn't seem to get the exact structure of the order of the functions in the files. Also, please pay attention to how I tested the function in machine_test.go, as I'm not super confident that's where it should be, but it feels right.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.