Added API functionality + testing to change engine IO type #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Son <[email protected]>
austinvazquez
approved these changes
Jun 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Drive model has a variable called
IoEnginethat determines if the block device runs commands synchronously or asynchronously (default synchronous). This PR implements a function to change said variable alongside a test to show that it works.The default value seems to be nil and I assume that the handling of that is done in Firecracker itself, but if this is not the case, please let me know.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.