Add mmds version 2 support

[Joffref]

Closes #437

Signed-off-by: Mathis Joffre [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[Kern--]

LGTM pending #445 to verify the new integration tests. Thanks!

[Joffref]

I squashed my two commits together but I don't find a proper way to squash the squashed commit and merge commit.

[austinvazquez]

I squashed my two commits together but I don't find a proper way to squash the squashed commit and merge commit.

My method is to rebase off main and force push to the PR branch, but I can squash and merge on this end if that helps.

[Joffref]

My method is to rebase off main and force push to the PR branch, but I can squash and merge on this end if that helps.

Thanks for the advice @austinvazquez , I will try next time.

Thanks for the merge too, but as I see it seems buildkite failed due to network problems.

=== CONT  TestLoadSnapshot

    machine_test.go:2134: 

        	Error Trace:	/local/home/buildkite-agent/builds/ip-10-0-0-177-12/firecracker-microvm/firecracker-go-sdk/machine_test.go:2134

        	            				/local/home/buildkite-agent/builds/ip-10-0-0-177-12/firecracker-microvm/firecracker-go-sdk/machine_test.go:2260

        	Error:      	Received unexpected error:

        	            	dial tcp 10.168.0.3:22: connect: no route to host

        	Test:       	TestLoadSnapshot

time="2022-08-31T15:03:28Z" level=info msg="Sent instance shutdown request: [PUT /actions][204] createSyncActionNoContent "

It's not the first time I see this, maybe the test is unstable but I don't know why. An issue should be raised, I think.

[austinvazquez]

Thanks for the advice @austinvazquez , I will try next time.

Thanks for the merge too, but as I see it seems buildkite failed due to network problems.

=== CONT  TestLoadSnapshot

    machine_test.go:2134: 

        	Error Trace:	/local/home/buildkite-agent/builds/ip-10-0-0-177-12/firecracker-microvm/firecracker-go-sdk/machine_test.go:2134

        	            				/local/home/buildkite-agent/builds/ip-10-0-0-177-12/firecracker-microvm/firecracker-go-sdk/machine_test.go:2260

        	Error:      	Received unexpected error:

        	            	dial tcp 10.168.0.3:22: connect: no route to host

        	Test:       	TestLoadSnapshot

time="2022-08-31T15:03:28Z" level=info msg="Sent instance shutdown request: [PUT /actions][204] createSyncActionNoContent "

It's not the first time I see this, maybe the test is unstable but I don't know why. An issue should be raised, I think.

It is somewhat a pipeline issue. #418 is one solution, but long story short the pipeline builds a rootfs using Firecracker's devtool which can sometimes silently fail. Not related to your change.

[Joffref]

I see, thanks for you explanation @austinvazquez . 💯