fix: Add keyboard drivers to CI guest kernels #5051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a tree-less git checkout [1], which reduces the amount of data downloaded by ~60% (from >3GiB to ~1GiB currently) when cloneing the upstream amazon linux repository from GitHub. It will now download some stuff during checkout, but this is significantly less than a full clone, as we're only checking out a handful of tags. We sadly cannot use a `--depth=1` checkout because we need access to all tags, in chronological order, and for this, we need at least the commit metadata itself fetched locally (even git ls-remote --tags will not sort tags without first fetching these). [1]: https://github.blog/open-source/git/get-up-to-speed-with-partial-clone-and-shallow-clone/ Signed-off-by: Patrick Roy <[email protected]>
Firecracker supports sending a CTRL+ALT+DEL event to the guest, to trigger a reboot, and we had an integration test for this. However, the integration test was broken (see firecracker-microvm#5050), and actually, our guest kernels dont have the necessary drivers compiled in to actually receive the CTRL+ALT+DEL. Fix this by actually enabling the relavant Kconfigs. We don't re-build the artifacts just yet, as it'll happen anyway in a few days when we branch off the next release. Suggested-by: Riccardo Mancini <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5051 +/- ##
=======================================
Coverage 83.19% 83.19%
=======================================
Files 247 247
Lines 26641 26641
=======================================
Hits 22163 22163
Misses 4478 4478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
approved these changes
Feb 26, 2025
Manciukic
approved these changes
Feb 26, 2025
zulinx86
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firecracker supports sending a CTRL+ALT+DEL event to the guest, to
trigger a reboot, and we had an integration test for this. However, the
integration test was broken (see #5050), and actually, our guest kernels
dont have the necessary drivers compiled in to actually receive the
CTRL+ALT+DEL.
Fix this by actually enabling the relavant Kconfigs. We don't re-build
the artifacts just yet, as it'll happen anyway in a few days when we
branch off the next release.
tested it on ARM as well, the kernel just ignores the superfluous config options it seems
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.