Skip to content

Conversation

@JackThomson2
Copy link
Contributor

We received a back-port adding KVM support for physical timers on ARM. With this two new registers are set:

Updated the fingerprint to include these new registers.

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@JackThomson2 JackThomson2 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Mar 10, 2025
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (1accef6) to head (83e1274).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5073   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files         248      248           
  Lines       26901    26901           
=======================================
  Hits        22370    22370           
  Misses       4531     4531           
Flag Coverage Δ
5.10-c5n.metal 83.52% <ø> (ø)
5.10-m5n.metal 83.51% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.71% <ø> (ø)
5.10-m6g.metal 79.60% <ø> (ø)
5.10-m6i.metal 83.50% <ø> (ø)
5.10-m7g.metal 79.60% <ø> (ø)
6.1-c5n.metal 83.57% <ø> (ø)
6.1-m5n.metal 83.55% <ø> (ø)
6.1-m6a.metal 82.76% <ø> (ø)
6.1-m6g.metal 79.60% <ø> (ø)
6.1-m6i.metal 83.54% <ø> (ø)
6.1-m7g.metal 79.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Manciukic
Manciukic previously approved these changes Mar 10, 2025
@JackThomson2 JackThomson2 force-pushed the tests/update_arm_fingerprint branch 2 times, most recently from 812ed05 to 459877c Compare March 10, 2025 15:42
@JackThomson2 JackThomson2 changed the title chore: Update fingerprint Update fingerprints and Enable physical counter test on AL Mar 10, 2025
@JackThomson2 JackThomson2 changed the title Update fingerprints and Enable physical counter test on AL Update fingerprints and enable physical counter test on AL Mar 10, 2025
roypat
roypat previously approved these changes Mar 10, 2025
We received a backport adding KVM support for physical timers on ARM.
As a result two new registers are set:

 - CNTHP_CTL_EL2
 - CNTHPS_CVAL_EL2

Updated the fingerprint to include these new registers.

Signed-off-by: Jack Thomson <[email protected]>
Enable the physical counter tests to run on amazon linux 2 or 2023 as
the KVM support for these has been backported from 6.4.

Signed-off-by: Jack Thomson <[email protected]>
Use a bigger comparison during our assertion of the physical counter
reset. The previous value was a little too low and would sometimes fail.

Signed-off-by: Jack Thomson <[email protected]>
@JackThomson2 JackThomson2 merged commit d2db352 into firecracker-microvm:main Mar 11, 2025
6 of 7 checks passed
@JackThomson2 JackThomson2 deleted the tests/update_arm_fingerprint branch March 11, 2025 09:21
@Manciukic Manciukic mentioned this pull request Mar 18, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants