-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update fingerprints and enable physical counter test on AL #5073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JackThomson2
merged 3 commits into
firecracker-microvm:main
from
JackThomson2:tests/update_arm_fingerprint
Mar 11, 2025
Merged
Update fingerprints and enable physical counter test on AL #5073
JackThomson2
merged 3 commits into
firecracker-microvm:main
from
JackThomson2:tests/update_arm_fingerprint
Mar 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5073 +/- ##
=======================================
Coverage 83.15% 83.15%
=======================================
Files 248 248
Lines 26901 26901
=======================================
Hits 22370 22370
Misses 4531 4531
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
previously approved these changes
Mar 10, 2025
812ed05 to
459877c
Compare
roypat
previously approved these changes
Mar 10, 2025
We received a backport adding KVM support for physical timers on ARM. As a result two new registers are set: - CNTHP_CTL_EL2 - CNTHPS_CVAL_EL2 Updated the fingerprint to include these new registers. Signed-off-by: Jack Thomson <[email protected]>
Enable the physical counter tests to run on amazon linux 2 or 2023 as the KVM support for these has been backported from 6.4. Signed-off-by: Jack Thomson <[email protected]>
Use a bigger comparison during our assertion of the physical counter reset. The previous value was a little too low and would sometimes fail. Signed-off-by: Jack Thomson <[email protected]>
7248d9c to
83e1274
Compare
roypat
approved these changes
Mar 10, 2025
ShadowCurse
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received a back-port adding KVM support for physical timers on ARM. With this two new registers are set:
Updated the fingerprint to include these new registers.
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.