-
Notifications
You must be signed in to change notification settings - Fork 332
util/simd: Add uchar vectors (vb, wb) #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumpsiegel
previously approved these changes
Apr 24, 2023
lheeger-jump
suggested changes
May 5, 2023
9c77207
to
1b111b1
Compare
ripatel-fd
approved these changes
May 10, 2023
ripatel-fd
requested changes
May 10, 2023
d380bf9
to
3441519
Compare
ripatel-fd
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
lheeger-jump
approved these changes
May 15, 2023
3441519
to
5dc640d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unsigned char (i.e. byte) support to the SIMD library. This is useful for Reed-Solomon and base58. I didn't add support for signed characters due to limited utility and
signed char/char
grossness, but I can if there's interest.