Skip to content

Conversation

ptaffet-jump
Copy link
Contributor

@ptaffet-jump ptaffet-jump commented Apr 13, 2023

Adds unsigned char (i.e. byte) support to the SIMD library. This is useful for Reed-Solomon and base58. I didn't add support for signed characters due to limited utility and signed char/char grossness, but I can if there's interest.

@ripatel-fd ripatel-fd added the perf Performance optimization label Apr 13, 2023
jumpsiegel
jumpsiegel previously approved these changes Apr 24, 2023
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@ptaffet-jump ptaffet-jump requested a review from lheeger-jump May 15, 2023 16:18
@ptaffet-jump ptaffet-jump added this pull request to the merge queue May 15, 2023
Merged via the queue into main with commit 848057e May 15, 2023
@ptaffet-jump ptaffet-jump deleted the ptaffet/simd_bytes branch May 15, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf Performance optimization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants