flamenco: fix return values for is_signer and is_writable instr acct functions #6650

ravyu-jump · 2025-10-07T21:26:51Z

flamenco: separate instruction error code and return value for fd_instr_acc_is_signer_idx
flamenco: disambiguate fd_instr_acc_is_writable_idx return value

github-actions · 2025-10-07T21:35:02Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.097497 s`	`0.097849 s`	`0.361%` ✅
backtest `mainnet-368528500-perf` snapshot load	`3 s`	`2.9 s`	`-3.333%` ✅
backtest `mainnet-368528500-perf` total elapsed	`97.497102 s`	`97.849231 s`	`0.361%` ✅
`firedancer mem` usage with `mainnet.toml`	`1009.12 GiB`	`1009.12 GiB`	`0.000%` ✅

github-actions · 2025-10-07T22:33:12Z

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.097982 s`	`0.098134 s`	`0.155%` ✅
backtest `mainnet-368528500-perf` snapshot load	`3 s`	`2.9 s`	`-3.333%` ✅
backtest `mainnet-368528500-perf` total elapsed	`97.982117 s`	`98.134257 s`	`0.155%` ✅
`firedancer mem` usage with `mainnet.toml`	`1009.12 GiB`	`1009.12 GiB`	`0.000%` ✅

github-actions · 2025-10-08T15:53:39Z

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.099388 s`	`0.099497 s`	`0.110%` ✅
backtest `mainnet-368528500-perf` snapshot load	`3 s`	`2.9 s`	`-3.333%` ✅
backtest `mainnet-368528500-perf` total elapsed	`99.387967 s`	`99.496586 s`	`0.109%` ✅
`firedancer mem` usage with `mainnet.toml`	`1008.12 GiB`	`1008.12 GiB`	`0.000%` ✅

src/flamenco/runtime/context/fd_exec_instr_ctx.c

src/flamenco/runtime/info/fd_instr_info.h

src/flamenco/runtime/program/fd_loader_v4_program.c

src/flamenco/runtime/program/fd_vote_program.c

mjain-jump

few nits

…_instr_acc_is_signer_idx

github-actions · 2025-10-08T17:18:25Z

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.099213 s`	`0.099209 s`	`-0.004%` ✅
backtest `mainnet-368528500-perf` snapshot load	`2.9 s`	`2.9 s`	`0.000%` ✅
backtest `mainnet-368528500-perf` total elapsed	`99.213483 s`	`99.208967 s`	`-0.005%` ✅
`firedancer mem` usage with `mainnet.toml`	`1008.12 GiB`	`1008.12 GiB`	`0.000%` ✅

mjain-jump

lgtm

ravyu-jump force-pushed the fix-is-signer-ret-val branch from 70b46d9 to e552159 Compare October 7, 2025 21:28

intrigus-lgtm mentioned this pull request Oct 7, 2025

codeql: add query for "non binary" is function #6652

Open

ravyu-jump force-pushed the fix-is-signer-ret-val branch from e552159 to 9b80814 Compare October 7, 2025 22:26

ravyu-jump force-pushed the fix-is-signer-ret-val branch from 9b80814 to 7490633 Compare October 8, 2025 15:47